Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[FEATURE] <Add Pagination to the Repos Page> #10054

Closed
1 task done
dhruvilmehta opened this issue Dec 30, 2023 · 4 comments
Closed
1 task done

[FEATURE] <Add Pagination to the Repos Page> #10054

dhruvilmehta opened this issue Dec 30, 2023 · 4 comments
Labels
⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@dhruvilmehta
Copy link
Member

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

Currently, we are fetching every relevant Repos record and passing it to the front end. Instead, we can add pagination and make pages of 10 or 20

Proposed Solution

Similar to how we are passing a query parameter of sortBy here, router.push(`/repos?sortBy=${e.currentTarget.value}`), we can also add the ?page parameter so that we can fetch a particular number of records from the backend.
For eg, if the Page Number is 1, we'll fetch first 10 records, if it is 2, we'll fetch next 10 records and display it on the screen and so on.

Screenshots

No response

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

As I explained in the proposed solution, we can add the query parameter of ?page and accordingly fetch relevant records.

@dhruvilmehta dhruvilmehta added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Dec 30, 2023
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
@SaraJaoude
Copy link
Member

Thank you raising. However given that it is unlikely that any individual user would have so many repos that this would require pagination, I will be closing this issue for now.

@SaraJaoude SaraJaoude closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2024
@EddieHubCommunity EddieHubCommunity unlocked this conversation Jan 20, 2024
@dhruvilmehta
Copy link
Member Author

I am talking about the general repos page which is https://www.biodrop.io/repos and not the individual user's repos page.

@eddiejaoude
Copy link
Member

Sorry that was my mistake when discussing with Sara - but tbh at the moment I quite like the longer page, but soon it will be needed - maybe we can revisit this after it grows a bit more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

No branches or pull requests

3 participants