Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any improvement on the view feature? #29

Open
snapxtp opened this issue May 7, 2018 · 2 comments
Open

Is there any improvement on the view feature? #29

snapxtp opened this issue May 7, 2018 · 2 comments

Comments

@snapxtp
Copy link

snapxtp commented May 7, 2018

Hi;
is it possible to add Google ads to a scrollview ? I am sure it is one of the most needed things...
It would have been great if the ads were added to the scrollview areas, not the bottom or the top, in a fixed way.

@EddyVerbruggen
Copy link
Owner

Nope, but for anyone reading this: feel free to add a 👍or try creating a PR.

@bigradish
Copy link

+1
I think it will be better if the createBanner-like methods can just return a view (promise on success) containing the ad which can be put anywhere on the page. Or the view option can be set to a container view to display the ad.
BTW, on nativescript 3.4.3, I failed to show ads with this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants