Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support in the datatable wrapper #101

Open
4 tasks
EitanBlumin opened this issue Mar 28, 2019 · 0 comments
Open
4 tasks

Add i18n support in the datatable wrapper #101

EitanBlumin opened this issue Mar 28, 2019 · 0 comments
Assignees
Labels
easy win Should be a fast and easy task enhancement New feature or request good first issue Good first issue help wanted Extra attention is needed optional Low priority enhancement, not actually requirement for product
Milestone

Comments

@EitanBlumin
Copy link
Owner

EitanBlumin commented Mar 28, 2019

Base:
https://datatables.net/manual/i18n

  • Add "language" element to the respite_crud static class in datatable_respite_crud.js
  • Add static function to translate a string based on the language element. If not found in element, return original string input, but log warning in console about the missing translation.
  • Replace all literal strings used in the script with the translation function, and add each such string to the language element.
  • Add an Ajax function to load a json file to use as language element, same as in datatables.
@EitanBlumin EitanBlumin added enhancement New feature or request good first issue Good first issue optional Low priority enhancement, not actually requirement for product labels Mar 28, 2019
@EitanBlumin EitanBlumin added this to the Alpha release 1 milestone Mar 28, 2019
@EitanBlumin EitanBlumin self-assigned this Mar 28, 2019
@EitanBlumin EitanBlumin added easy win Should be a fast and easy task good first issue Good first issue and removed good first issue Good first issue labels Mar 28, 2019
@EitanBlumin EitanBlumin added the help wanted Extra attention is needed label Apr 10, 2019
@EitanBlumin EitanBlumin changed the title Add localization support in the datatable wrapper Add i18n support in the datatable wrapper Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy win Should be a fast and easy task enhancement New feature or request good first issue Good first issue help wanted Extra attention is needed optional Low priority enhancement, not actually requirement for product
Projects
None yet
Development

No branches or pull requests

1 participant