Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives on older Android Chrome versions #15

Open
robcaldecottvelo opened this issue Feb 14, 2020 · 1 comment
Open

False positives on older Android Chrome versions #15

robcaldecottvelo opened this issue Feb 14, 2020 · 1 comment

Comments

@robcaldecottvelo
Copy link

Environment

  • Plugin Version: 0.5.6
  • Webpack Version: 4.41.5
  • OS Version: OSX 10.15.2
  • Node Version: Node 10
  • NPM Version: NPM 6
  • Browser Version: Chrome 79.0.3945.117

We are trying to use this plugin to display an "unsupported browser" message on all versions of IE and versions of iOS earlier than 11 (as we know these browsers do not work with our apps.)

For all other browsers we do not want to show a message. With that in mind we are trying to use something like the following plugin settings:

{
  browsers: ["cover 100%, not iOS < 11, not IE <= 11"],
  promptOnUnknownBrowser: false,
  promptOnNonTargetBrowser: false
}

This does exactly what we need with one exception: versions of Chrome on Android earlier than 79 cause the message to appear which seems to be an issue with the query results:

npx browserslist "cover 100%, not iOS < 11, not IE <= 11"

and_chr 79
and_ff 68
<snip>

I realise this is not a direct issue with this plugin per-se but I am after any ideas we can use to stop the message appearing on Android Chrome short of forking this plugin and trying to add a hard-coded exception.

@chikara-chan
Copy link
Contributor

chikara-chan commented Mar 10, 2020

@robcaldecottvelo
npx browserslist "cover 100%, not iOS < 11, not IE <= 11, not last 1 ChromeAndroid version"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants