-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Player Count #51
Comments
Hi! Sorry for the late reply. Yes, I'm using the community voted player counts. That means the number is not "The intended number of players from the manufacturer is X" but "This game with good with X players". Are the votes wrong with Small Railroad Empires? |
No worries it was the holidays, totally get it.
Yes the vote counts suggest 1P is "not recommended" with Small Railroad
Empires, but the rules (and the non-communist BGG player count) both allow
1P.
For most games/player counts the community recommendations are probably
good, but for 1P-capable games there are going to be "opinion" votes on
whether the solitaire is good or not, whether or not it's *possible*.
I use your tool to find things to play from my collection, and having the
1P (and sometimes 2P) options hidden kind of ruins my current use cases,
given how things are.
…On Wed, Jan 12, 2022, 2:38 PM Emil Stenström ***@***.***> wrote:
Hi! Sorry for the late reply.
Yes, I'm using the community voted player counts. That means the number is
not "The intended number of players from the manufacturer is X" but "This
game with good with X players". Are the votes wrong with Small Railroad
Empires?
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADAU3JC4HXJLIYSKRPJ2TUDUVX7FTANCNFSM5JVFUL4Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I went through my games to look for missing 1P games, the following are also not shown as 1P games (I didn't look for missing 2P or higher counts though, but I feel like I have some that don't show up for player counts I expect)
If you need more examples I can cross-correlate 2P games too. |
Thanks for the examples. It makes sense to go with the official numbers. And maybe just mark the version that are recommended by the community, then the user can make an informed decision. If you are able to submit a PR, I'd happily accept it! |
Sadly my new job has more restrictions and rules to contribute to projects, I haven't yet taken the time to go through it all. If there's not a quick fix you can add ( I'm really hoping its of the form |
I think italics alone for "supported but not recommended" is prolly good enough. I agree the extra symbol gets a bit messy. But looks good otherwise! Arbitrary cutoff above some number (13-15 seems reasonable, to include things like Werewolf and roll-n-writes) is prolly reasonable. |
Im not a fan of putting in the not recommended. I never use the player count information from bgg except to know the actual supported counts. I like the idea of putting the star by the recommended, even if I dont agree or care, but I would stop there. Also instead of listing each player count individually just put the official count as "x - y", then a comma separated list of recommended counts preceeded by a star to indicate recommended |
@Medwynd The star (and circled-cross for "with expansion") should already be part of the code base (my page shows them, and I shouldn't have any local changes). If you're not seeing them, could you be out of date wrt to Emil's upstream? As for the range, the issue comes down to search and filtering. I'd like to be able to list all my N-player games, regardless of whether it's a recommended count, and I suspect a range would not play nicely with the current "player count" dropdown filter. It could be made to work I'm sure, but that's now a larger changeset. And knowing the "supported count" is specifically the feature I want (you can of course disagree with what's desirable behavior). |
@tapanther I agree that italics should be enough. @boglesby03 Would love to check out a PR, thanks! :) @Medwynd I think it makes sense to include supported counts, especially with respect to games with few community votes, where the supported count is better than the community one. |
Not sure if this is happening with other games, but Small Railroad Empires is listed as 1-4 players in BGG but 3-4 in the generated website.
I did notice that the "Community" Player Count is 3-4, could that be getting parsed as the player count?
Images in case links aren't useful/broken/fixed/etc.


The text was updated successfully, but these errors were encountered: