Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Always showing death messages even with the gamerule "showdeathmessages" set to false, and not translating to other languages properly #138

Open
SuperEric1 opened this issue Feb 20, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@SuperEric1
Copy link

SuperEric1 commented Feb 20, 2025

Describe the bug
When a entity or player gets killed, it shows a message in chat. But this shouldn't happen when the gamerule "showdeathmessage" is set to false. The death messages also doesn't get translated to other languages, only shows in English.

To Reproduce
Steps to reproduce the behavior:

  1. Set the gamerule "showdeathmessages" to false using the /gamerule showdeathmessages false command;
  2. Kill a player or entity with the /kill command or anything else
  3. The death message will appear on the chat.

Expected behavior
When the gamerule is set to false, it shouldn't display the death messages on the chat. The messages should also be translated to the player's game language in the chat, which it doesn't

Details (please complete the following information):

  • OS: Windows 10
  • Endstone Version: 6.0.1

Additional context
A similar thing happens with the "sendcommandfeedback" gamerule, which when set to false should also hide command execution messages on the chat.

@SuperEric1 SuperEric1 added the bug Something isn't working label Feb 20, 2025
@wu-vincent
Copy link
Member

Can confirm this is a regression due to the recent refactoring of the codebase. Will fix it soon.

@wu-vincent wu-vincent self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants