Trouble constructing a type that requires type parameters

[glwagner]

For example RectilinearGrid has an inner constructor of the form RectilinearGrid{TX, TY, TZ}(args...).

This error comes from includeing

https://github.com/CliMA/Oceananigans.jl/blob/glw/arch-dep-clock/test/test_reactant.jl

which can be done by cloning Oceananigans, navigating to test/ and typing

using TestEnv; TestEnv.activate()
include("test_reactant.jl")

btw also requires #810 so if that isn't merged yet, need to dev or add the Reactant branch explicitly.

cc @avik-pal

error: https://gist.github.com/glwagner/cba29b2dcaee57e1cc7f5d428386a65d

[avik-pal]

Can we add ConstructorBase definitions for these types in Oceananigans? Similar to https://juliaobjects.github.io/ConstructionBase.jl/dev/#ConstructionBase.constructorof

[avik-pal]

using ConstructionBase: ConstructionBase

function ConstructionBase.constructorof(::Type{<:RectilinearGrid{FT, TX, TY, TZ}}) where {FT, TX, TY, TZ}
    return RectilinearGrid{TX, TY, TZ}
end

[glwagner]

Seems easy enough

[glwagner]

There are probably a fair number of these so we will have to see how many to add