[WIP] control flow if #735
Open
+115
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumerckx
reviewed
Feb 12, 2025
| src = CC.retrieve_code_info(result.linfo, world) | ||
| #dico2[mi]=(CC.copy(src), goto_if_not_protection(src)) | ||
| @error src | ||
| src = goto_if_not_protection(src) |
There was a problem hiding this comment.
Billy's concern was that since the transformation here happens before inlining, the code that will later get doesn't have the needed conversions inserted.
I'm wondering if you run into this issue?
If so, the idea was to do the transformation by specializing the abstract interpreter.
If that's necessary, the correct place to do it would be InferenceState like I did here:
https://github.com/JuliaLLVM/MLIR.jl/blob/cf22c54222033ed4f5f3d68a620448bcaf766ac4/src/Generate/absint.jl#L151C1-L160C4
based on an old pr from valentin:
JuliaGPU/GPUCompiler.jl#311
There was a problem hiding this comment.
I don't have an example of such a case in mind! I will try with this one firstly (seem easier to handle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to test with CI.