feat: JLL changes for IFRT integration #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
commented
Feb 23, 2025
| *error = "Could not find TPU path"; | ||
| return nullptr; | ||
| } | ||
| // XXX: Bring back with the correct API |
There was a problem hiding this comment.
The proxy APIs need to be setup with the correct kv_store from the DistributedRuntimeClient without which they should anyways fail. I will bring these ones back once the IFRT-PJRT clients land
avik-pal
force-pushed
the
ap/ifrt_jll_changes
branch
2 times, most recently
from
a281552 to
56818bc
Compare
avik-pal
force-pushed
the
ap/ifrt_jll_changes
branch
from
56818bc to
70b2b43
Compare
|
Builds are going though and none of the current tests are for IFRT merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.