Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is settings.SongHint really necessary? #1744

Closed
ccuser44 opened this issue Nov 20, 2024 · 1 comment
Closed

Is settings.SongHint really necessary? #1744

ccuser44 opened this issue Nov 20, 2024 · 1 comment
Labels
✨ enhancement Enhancing or improving existing functionality 🖇️ loader The Adonis Loader and loader settings

Comments

@ccuser44
Copy link
Contributor

What part of Adonis is this related to?

Loader/Settings

What are you suggesting?

Do we really need it? Maybe? Maybe not?

@ccuser44 ccuser44 added the ✨ enhancement Enhancing or improving existing functionality label Nov 20, 2024
@github-actions github-actions bot added the 🖇️ loader The Adonis Loader and loader settings label Nov 20, 2024
@GalacticInspired
Copy link
Member

Yes we do, it is a setting for a reason. Some experiences, like theater games, may want to notify all users when a host is playing music, while some games may not want to do that.

@GalacticInspired GalacticInspired closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Enhancing or improving existing functionality 🖇️ loader The Adonis Loader and loader settings
Projects
None yet
Development

No branches or pull requests

2 participants