From 663f2dd24c72f9a2d9669ae9b2820d04f807918d Mon Sep 17 00:00:00 2001 From: Ty Potter Date: Tue, 3 Dec 2024 12:30:12 -0700 Subject: [PATCH] tweaked files --- .../EppoSDKRelay/EppoSDKRelay.csproj | 2 +- .../dotnet-sdk-relay/EppoSDKRelay/Startup.cs | 2 +- .../php-sdk-relay/src/BanditHandler.php | 21 +++++++------------ .../src/protocol/ServerSDKRelay.ts | 3 +++ .../jit-loading-2/bandit-flags-v1.json | 10 ++++----- .../jit-loading-2/bandit-models-v1.json | 2 +- .../test-case-second-bandit-cold-start.json | 12 +++++------ 7 files changed, 24 insertions(+), 28 deletions(-) diff --git a/package-testing/dotnet-sdk-relay/EppoSDKRelay/EppoSDKRelay.csproj b/package-testing/dotnet-sdk-relay/EppoSDKRelay/EppoSDKRelay.csproj index 0bebc0a6..f5c60633 100644 --- a/package-testing/dotnet-sdk-relay/EppoSDKRelay/EppoSDKRelay.csproj +++ b/package-testing/dotnet-sdk-relay/EppoSDKRelay/EppoSDKRelay.csproj @@ -7,7 +7,7 @@ - + diff --git a/package-testing/dotnet-sdk-relay/EppoSDKRelay/Startup.cs b/package-testing/dotnet-sdk-relay/EppoSDKRelay/Startup.cs index ff4683a2..2e08433b 100644 --- a/package-testing/dotnet-sdk-relay/EppoSDKRelay/Startup.cs +++ b/package-testing/dotnet-sdk-relay/EppoSDKRelay/Startup.cs @@ -12,7 +12,7 @@ public class Startup public static void InitEppoClient() { - var url = "http://" + apiHost + ":" + apiPort; + var url = "http://" + apiHost + ":" + apiPort + "/api"; Console.WriteLine("Initializating SDK pointed at" + url); var eppoClientConfig = new EppoClientConfig(apiToken, new AssignmentLogger()) diff --git a/package-testing/php-sdk-relay/src/BanditHandler.php b/package-testing/php-sdk-relay/src/BanditHandler.php index 9f72c7d2..25a705f0 100644 --- a/package-testing/php-sdk-relay/src/BanditHandler.php +++ b/package-testing/php-sdk-relay/src/BanditHandler.php @@ -20,7 +20,6 @@ public function getBanditAction(array $payload): array { $consoleLogger = new Logger(); $consoleLogger->log(LogLevel::INFO, "Processing Bandit"); - $consoleLogger->log(LogLevel::DEBUG, json_encode($payload, true)); $flagKey = $payload['flag']; $default = $payload['defaultValue']; @@ -39,19 +38,6 @@ public function getBanditAction(array $payload): array $payload['subjectAttributes']['categoricalAttributes'] ); - $consoleLogger->log( - LogLevel::INFO, - var_export( - [ - $flagKey, - $subjectKey, - $subjectAttributes, - $actions, - $default - ], - true - ) - ); try { $result = $this->eppoClient->getBanditAction( @@ -68,6 +54,13 @@ public function getBanditAction(array $payload): array "assignmentLog" => $this->eppoEventLogger->assignmentLogs, "banditLog" => $this->eppoEventLogger->banditLogs ]; + // $consoleLogger->log( + // LogLevel::INFO, + // var_export( + // $results, + // true + // ) + // ); } catch (EppoClientException $e) { $results = array( "subjectKey" => $subjectKey, diff --git a/package-testing/sdk-test-runner/src/protocol/ServerSDKRelay.ts b/package-testing/sdk-test-runner/src/protocol/ServerSDKRelay.ts index e894b3c4..1b0c5e8c 100644 --- a/package-testing/sdk-test-runner/src/protocol/ServerSDKRelay.ts +++ b/package-testing/sdk-test-runner/src/protocol/ServerSDKRelay.ts @@ -6,6 +6,7 @@ import { SDKRelay } from './SDKRelay'; import { SDKInfo } from './SDKInfo'; import { SDKConnectionFailure } from './SDKConnectionFailure'; import { ASSIGNMENT_PATH, BANDIT_PATH, RESET_PATH } from './constants'; +import { log } from '../logging'; /** * Uses `axios` to communicate with a Server SDK Relay via http @@ -37,6 +38,7 @@ export class ServerSDKRelay implements SDKRelay { async getBanditAction(request: BanditActionRequest): Promise { const result = await axios.post(`${this.sdkRelayAddress}${BANDIT_PATH}`, request); + log(result.data); return result.data as TestResponse; } @@ -45,6 +47,7 @@ export class ServerSDKRelay implements SDKRelay { } async getAssignment(request: AssignmentRequest): Promise { + log('GETING ASS'); return axios.post(`${this.sdkRelayAddress}${ASSIGNMENT_PATH}`, request).then((result) => { return result.data as TestResponse; }); diff --git a/ufc/scenarios/jit-loading-2/bandit-flags-v1.json b/ufc/scenarios/jit-loading-2/bandit-flags-v1.json index 03304db6..049ad634 100644 --- a/ufc/scenarios/jit-loading-2/bandit-flags-v1.json +++ b/ufc/scenarios/jit-loading-2/bandit-flags-v1.json @@ -1,5 +1,5 @@ { - "createdAt": "2024-04-17T19:40:53.716Z", + "createdAt": "2024-04-18T19:40:53.716Z", "format": "SERVER", "environment": { "name": "Test" @@ -31,7 +31,7 @@ "totalShards": 10000 }, "second_cold_start_bandit_flag": { - "key": "cold_start_bandit_flag", + "key": "second_cold_start_bandit_flag", "enabled": true, "variationType": "STRING", "variations": { @@ -54,7 +54,7 @@ } ], "totalShards": 10000 - } + } }, "bandits": { "cold_start_bandit": [ @@ -72,7 +72,7 @@ "variationKey": "second_cold_start_bandit", "variationValue": "second_cold_start_bandit" } - ] + ] }, "banditReferences": { "cold_start_bandit": { @@ -97,7 +97,7 @@ "variationValue": "second_cold_start_bandit" } ], - "modelVersion": "NOT cold start" + "modelVersion": "cold start" } } } diff --git a/ufc/scenarios/jit-loading-2/bandit-models-v1.json b/ufc/scenarios/jit-loading-2/bandit-models-v1.json index 3605a6e5..fd7984c5 100644 --- a/ufc/scenarios/jit-loading-2/bandit-models-v1.json +++ b/ufc/scenarios/jit-loading-2/bandit-models-v1.json @@ -20,7 +20,7 @@ "banditKey": "second_cold_start_bandit", "modelName": "falcon", "updatedAt": "2023-09-13T04:52:06.462Z", - "modelVersion": "NOT cold start", + "modelVersion": "cold start", "modelData": { "gamma": 1.0, "defaultActionScore": 0.0, diff --git a/ufc/scenarios/jit-loading-2/tests/test-case-second-bandit-cold-start.json b/ufc/scenarios/jit-loading-2/tests/test-case-second-bandit-cold-start.json index be04ddf5..c0504aa1 100644 --- a/ufc/scenarios/jit-loading-2/tests/test-case-second-bandit-cold-start.json +++ b/ufc/scenarios/jit-loading-2/tests/test-case-second-bandit-cold-start.json @@ -1,9 +1,9 @@ { - "flag": "cold_start_bandit_flag", + "flag": "second_cold_start_bandit_flag", "defaultValue": "default", "subjects": [ { - "subjectKey": "alice", + "subjectKey": "ephraim", "subjectAttributes": { "numericAttributes": {}, "categoricalAttributes": {} @@ -25,7 +25,7 @@ "categoricalAttributes": {} } ], - "assignment": {"variation": "cold_start_bandit", "action": "red"} + "assignment": {"variation": "second_cold_start_bandit", "action": "blue"} }, { "subjectKey": "bob", @@ -50,10 +50,10 @@ "categoricalAttributes": {} } ], - "assignment": {"variation": "cold_start_bandit", "action": "green"} + "assignment": {"variation": "second_cold_start_bandit", "action": "green"} }, { - "subjectKey": "charles", + "subjectKey": "fiona", "subjectAttributes": { "numericAttributes": {}, "categoricalAttributes": {} @@ -75,7 +75,7 @@ "categoricalAttributes": {} } ], - "assignment": {"variation": "cold_start_bandit", "action": "blue"} + "assignment": {"variation": "second_cold_start_bandit", "action": "red"} } ] }