-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Modern (ES6+) JavaScript #1238
Comments
definitely should be. the first commit in #1201 contains an example. |
Related to all this: the latest |
Now in 2022, all these are now supported in the browsers we're supporting, so we're planning on switching the source code to use |
@gavinr related to this lets setup prettier as well and remove |
In the source of
esri-leaflet
, we'd like to start using more modern JavaScript, likeObject.assign()
, arrow functions, template strings, let/const, etc.I'm pretty sure that right now if we try to use any of that, it would cause the library not to work with versions of IE and per the wiki we should be supporting IE8+.
So, I'd like to propose changing build process for esri-leaflet to include a transpile step that would allow us to use some of these more modern JavaScript commands within the source, but the build process will allow the code to work with IE8+. It may be as simple as using @rollup/plugin-babel ... not quite sure. Looking for comments and input! Thanks!
The text was updated successfully, but these errors were encountered: