Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in masking tool #292

Open
jo-moeller opened this issue Mar 18, 2021 · 2 comments
Open

Bug in masking tool #292

jo-moeller opened this issue Mar 18, 2021 · 2 comments
Assignees

Comments

@jo-moeller
Copy link

I use EXtra-foam/alpha and EXtra-geom to assemble AGIPD tiles
Screenshot from 2021-03-18 14-47-44
When I then try to mask, I can't mask the lower part of the detector
Screenshot from 2021-03-18 14-47-22
This is as low as it gets. Everything below I can't draw a mask. I also get this output in the logger
Screenshot from 2021-03-18 14-46-46

@JamesWrigley JamesWrigley self-assigned this Mar 18, 2021
@JamesWrigley
Copy link
Member

JamesWrigley commented Mar 18, 2021

Confirmed, the problem is that extra-geom doesn't have the output_array_for_dismantle_fast() method mentioned in the error, which extra-foam's internal assembler does have. It will also need dismantle_all_modules(). It's breaking here: https://github.com/European-XFEL/EXtra-foam/blob/dev/extra_foam/pipeline/processors/image_processor.py#L281

I can't reproduce the issue with masking the lower part of the image though, does it work for you with the extra-foam assembler?

@jo-moeller
Copy link
Author

True, it acutally doesn't depend on using EXtra-foam or EXtra-geom for assembling the tiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants