Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gap parameter defaults where unit can also be passed. #100

Open
takluyver opened this issue Aug 24, 2021 · 0 comments
Open

Fix gap parameter defaults where unit can also be passed. #100

takluyver opened this issue Aug 24, 2021 · 0 comments

Comments

@takluyver
Copy link
Member

From discussion on #89: where from_* classmethods have a default for asic_gap or panel_gap, we don't want the default to be affected by passing unit=. So we should consistently use None as the default in the method signature, and set the real default inside the method. We already do this in most cases, but not all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant