Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARN THREE.Quaternion: .inverse() has been renamed to invert(). #28

Open
igorroman777 opened this issue May 17, 2021 · 8 comments
Open

Comments

@igorroman777
Copy link
Contributor

I am using expo-three with three.js.
After updating three.js to 0.128 I get the warning:

WARN THREE.Quaternion: .inverse() has been renamed to invert().

But I have no line in my code with: .inverse()

OrbitControls uses e.g. the

var quatInverse = quat.clone().inverse();

Yes, without OrbitControlsView there is no warning!

@wtlyu
Copy link

wtlyu commented Jan 11, 2022

same issue here

@im-ironclad
Copy link

FYI, Looks like a fix was merged here but i'm still getting the error as well. I've asked the maintainer why the error persist even after the MR was merged.

@changken
Copy link

changken commented Jun 6, 2022

I try to modify OrbitControls.js which is belong to the expo-three-orbit-controls.

Go to line 634, and I replaced inverse() to invert().

Then It works!

@aaronb97
Copy link

Can we get this change in the package? Is this project abandoned?

@Leandro201927
Copy link

for the moment we can fork this repo and do that change manually.

@foufrix
Copy link

foufrix commented Apr 20, 2023

FYI, Looks like a fix was merged here but i'm still getting the error as well. I've asked the maintainer why the error persist even after the MR was merged.

You can check line 634 current release on NPM do not have the change https://www.npmjs.com/package/expo-three-orbit-controls?activeTab=code

@alperbayram
Copy link

I try to modify OrbitControls.js which is belong to the expo-three-orbit-controls.

Go to line 634, and I replaced inverse() to invert().

Then It works!

After making this change, I can't zoom in or zoom out, the object disappears.

@Bosconovitchi
Copy link

modify Quaternion's prototype can fix this
Quaternion.prototype.inverse = function () { return this.invert() }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants