Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo image from Github API keeps changing url #66

Open
ffeltrinelli opened this issue Sep 17, 2024 · 2 comments
Open

Repo image from Github API keeps changing url #66

ffeltrinelli opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ffeltrinelli
Copy link
Contributor

The field openGraphImageUrl that we take from GH's GraphQL API and use for repository's image has this kind of pattern:

https://opengraph.githubassets.com/f738e6fb5f7a97257d275344c8890c6349cc60cd21803e606bc6ea8ca29ebf53/ExpediaGroup/expediagroup.github.io

where the hash in the middle seems to change too frequently. This is probably because the default generated image - in those cases where the repository owners did not specify a custom repo image - contains dynamic details.

Moreover, this default generated image does not seem to make much sense if shown as card in the website.

In these cases where the repo owners did not specify a repo image, should we just use a default Expedia image instead?

@ffeltrinelli ffeltrinelli self-assigned this Sep 17, 2024
@ffeltrinelli ffeltrinelli added the bug Something isn't working label Sep 17, 2024
@ffeltrinelli
Copy link
Contributor Author

I've uploaded a custom social image for this repo expediagroup.github.io, as it seems it was the url that was changing the most (I don't know why):

https://repository-images.githubusercontent.com/347094132/4a66b310-79fb-4d17-bc9d-deebf5558760

I'll monitor this for a while and see if this was enough to solve the problem.

@ffeltrinelli
Copy link
Contributor Author

The problem is still present, see this last commit: 3026063#diff-05d65c475110b16eee6544b05ca998ee1c0a3ae65f8ecbcd22c575f9dcfcceb7R82

The default social images are re-generated every now and then, even if the image looks exactly the same. See for example:
previous image: https://opengraph.githubassets.com/30f3dbdef05fe87d3bdedb5b08ea8cc2180adf96ad2d873b87e528d531f7f0cd/ExpediaGroup/cypress-codegen
new image: https://opengraph.githubassets.com/7577db48dde1f3adc46ae15e6d2d820f54d27b6eb9a4158b5186ec766d101d79/ExpediaGroup/cypress-codegen

I don't think we really need them, we could just put a default image in these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant