From 17c01f3a349c51a8748c6f999b11faa543e486be Mon Sep 17 00:00:00 2001 From: Vivek Kumar <35863227+techievivek@users.noreply.github.com> Date: Wed, 5 Feb 2025 17:50:40 +0530 Subject: [PATCH] Merge pull request #56397 from nkdengineer/fix/56307 fix: App is stuck on the confirmation page when submitting expense (cherry picked from commit f22c07bb7d083f201b397adb73bc8e0ffd32952c) (CP triggered by roryabraham) --- src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts | 2 +- .../API/parameters/ConvertTrackedExpenseToRequestParams.ts | 2 +- src/libs/actions/IOU.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts b/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts index 3c2441b205e4..02fdce59a173 100644 --- a/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts +++ b/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts @@ -17,7 +17,7 @@ type AddTrackedExpenseToPolicyParams = { customUnitRateID?: string; policyID: string; transactionID: string; - actionableWhisperReportActionID: string; + actionableWhisperReportActionID: string | undefined; moneyRequestReportID: string; reportPreviewReportActionID: string; modifiedExpenseReportActionID: string; diff --git a/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts b/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts index 21a59f7e614f..e0fad14b4fec 100644 --- a/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts +++ b/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts @@ -7,7 +7,7 @@ type ConvertTrackedExpenseToRequestParams = { payerAccountID: number; chatReportID: string; transactionID: string; - actionableWhisperReportActionID: string; + actionableWhisperReportActionID: string | undefined; createdChatReportActionID?: string; moneyRequestReportID: string; moneyRequestCreatedReportActionID: string | undefined; diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts index 731f8751f6d3..72c63789de2f 100644 --- a/src/libs/actions/IOU.ts +++ b/src/libs/actions/IOU.ts @@ -4155,7 +4155,7 @@ type AddTrackedExpenseToPolicyParam = { merchant: string; transactionID: string; reimbursable: boolean; - actionableWhisperReportActionID: string; + actionableWhisperReportActionID: string | undefined; moneyRequestReportID: string; reportPreviewReportActionID: string; modifiedExpenseReportActionID: string; @@ -4172,7 +4172,7 @@ function convertTrackedExpenseToRequest( payerEmail: string, chatReportID: string, transactionID: string, - actionableWhisperReportActionID: string, + actionableWhisperReportActionID: string | undefined, createdChatReportActionID: string | undefined, moneyRequestReportID: string, moneyRequestCreatedReportActionID: string | undefined, @@ -4425,7 +4425,7 @@ function requestMoney(requestMoneyInformation: RequestMoneyInformation) { switch (action) { case CONST.IOU.ACTION.SUBMIT: { - if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) { + if (!linkedTrackedExpenseReportAction || !linkedTrackedExpenseReportID) { return; } const workspaceParams =