Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-06] [TS migration] Migrate 'ReportUtils.js' lib to TypeScript #24927

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/ReportUtils.js 24
Issue OwnerCurrent Issue Owner: @lschurr
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@blazejkustra
Copy link
Contributor

@kubabutkiewicz No longer blocked, let's prioritize this issue! 😄

@melvin-bot melvin-bot bot added the Overdue label Oct 20, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 Overdue labels Nov 7, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
Copy link
Author

melvin-bot bot commented Nov 28, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportUtils.js' lib to TypeScript [HOLD for payment 2023-12-06] [TS migration] Migrate 'ReportUtils.js' lib to TypeScript Nov 29, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 29, 2023
Copy link
Author

melvin-bot bot commented Nov 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Nov 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@shubham1206agra
Copy link
Contributor

Please assign me here for C+

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 Daily KSv2 and removed Daily KSv2 Monthly KSv2 labels Dec 5, 2023
@shubham1206agra
Copy link
Contributor

@mountiny Can you reconsider the amount to be paid out for this issue, as this issue was more extensive and complex than other TS migration issues?

@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2023
@mountiny mountiny removed Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Dec 8, 2023
Copy link
Author

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2023
Copy link
Author

melvin-bot bot commented Dec 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

mountiny commented Dec 8, 2023

@shubham1206agra sorry these are standardized, some PRs on the other hand are super simple and quick so it balances out

@mountiny
Copy link
Contributor

mountiny commented Dec 8, 2023

$250 to @shubham1206agra

@lschurr
Copy link
Contributor

lschurr commented Dec 8, 2023

Not overdue. I'll review today and send payment.

@melvin-bot melvin-bot bot removed the Overdue label Dec 8, 2023
@lschurr
Copy link
Contributor

lschurr commented Dec 8, 2023

@shubham1206agra could you apply for the job here? https://www.upwork.com/jobs/~0167759a85082439d4

@shubham1206agra
Copy link
Contributor

Applied

@lschurr
Copy link
Contributor

lschurr commented Dec 8, 2023

Offer sent!

@lschurr
Copy link
Contributor

lschurr commented Dec 8, 2023

Payment issued in Upwork. Closing this one out.

@lschurr lschurr closed this as completed Dec 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

6 participants