Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wave 6: Drafts] Link an open report to a workspace chat if on paid policy #31657

Closed
mountiny opened this issue Nov 21, 2023 · 10 comments
Closed

[Wave 6: Drafts] Link an open report to a workspace chat if on paid policy #31657

mountiny opened this issue Nov 21, 2023 · 10 comments
Assignees
@mountiny
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Nov 21, 2023 •
edited by melvin-bot bot
Loading

Problem

With Free policies or with IOU reports, we start with processing state of a report and we keep adding the requests to that report. But for paid policies, right now the base is Open report, not processing.

Why is it important

Without this change, when user of paid policy requests money on NewDot, it would be added to processing report, which is not correct

Solution

When linking workspaceChat to an expense report using the iouReportID key, make sure to link to an open report if there is any

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0161694bef8896db3f
  • Upwork Job ID: 1727070555579027456
  • Last Price Increase: 2023-11-21
@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Nov 21, 2023
@mountiny mountiny self-assigned this Nov 21, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0161694bef8896db3f

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
@mountiny
Copy link
Contributor Author

Prioritized wave5 issues.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 24, 2023
@greg-schroeder greg-schroeder changed the title [Drafts] Link an open report to a workspace chat if on paid policy [Wave 6: Drafts] Link an open report to a workspace chat if on paid policy Nov 27, 2023
@mountiny
Copy link
Contributor Author

Will look into this today hopefully

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2023
@mountiny
Copy link
Contributor Author

Got one Pr merged but there is one more needed

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Dec 4, 2023

Probably will continue on this tomorrow

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Dec 5, 2023

Looking into this now, I will refactor this a bit to make it cleaner

@mountiny mountiny added the Reviewing Has a PR in review label Dec 7, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Dec 7, 2023

PR is in review

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 15, 2023

@mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor Author

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountiny mountiny

Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
No open projects
[#whatsnext] Wave 06 - Collect Submitters
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mollfpr @mountiny