[HOLD for payment 2025-01-28] [HOLD for payment 2025-01-24] [$250] Reports - App crashes after cancelling payment on expenses with violation

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.86-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: [email protected]
App Component: Search

Action Performed:

Precondition:

• "Members must categorize all expenses" is enabled in Categories settings.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses without category.
4. Go to Reports.
5. Go to Outstanding.
6. Click Review button on the group expense.
7. Click Approve > Approve all amount (if workspace has approvals).
8. Click Pay elsewhere.
9. Click on the report header.
10. Click Cancel payment.
11. Cancel the payment.
12. Close the RHP.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

bug.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879581827856936306
• Upwork Job ID: 1879581827856936306
• Last Price Increase: 2025-01-15
• Automatic offers:
• nkdengineer | Contributor | 105711398

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[rlinoz]

From the error, I think this line from this PR is the problem:

https://github.com/Expensify/App/pull/54847/files#diff-577fcc5f3a5e4930916ff310e61c38edfa093792fe3ab55b9a30d2aecd8811dbR6633

cc: @luacmartins in case you know an easy fix

[rlinoz]

I found a fix, will open a PR shortly

[luacmartins]

Thanks for investigating and finding a fix!

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes.

What is the root cause of that problem?

When we pay an expense, the violation is cleared but in the snapshot, we don't cover this case to store the value as an empty array. We only cover the case value is array without checking the current snapshot value is an array or not.

https://github.com/Expensify/react-native-onyx/pull/610/files#diff-2808ac0c9c00358eda8fccf46eb7303dabebfe3b4627c7b125dfc8dfe6edb0f2R585-R589

What changes do you think we should make in order to solve the problem?

Here we should also update the snap value to the value if snapshotData[key] is an array

if (Array.isArray(value) || Array.isArray(snapshotData[key])) {
    updatedData[key] = value || [];
    return;
}

https://github.com/Expensify/react-native-onyx/blob/9c028634e8b980772913455c8601eee69d4c8953/lib/Onyx.ts#L585-L587

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[nkdengineer]

@rlinoz What do you think about my proposal?

[parasharrajat]

I believe it is the same error as I reported here #54847 (comment). And the Onyx fix didn't fix it properly. @luacmartins @rlinoz there is a proposal above. What do you think about it>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879581827856936306

[luacmartins]

This is fixed in staging. Leading the issue open to process payment to @nkdengineer since they worked on a fix.

Additionally, this was also a regression from #54847, which had myself as the author and @parasharrajat as reviewer. I believe no further payments are needed for us.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump onyx version to 2.0.89 #55299

If no regressions arise, payment will be issued on 2025-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@parasharrajat @adelekennedy @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

@luacmartins @rlinoz

I wouldn't consider this a regression from the #54847 given the following reasons.

1. I did raise this issue on the PR Add violations to Search actions #54847 (comment).
2. The issue originates from higher-level lib but not from the code of that PR.
3. We did solve the issue and my test case passed.
4. I didn't get the chance to test the higher-level lib fix Process array merge in snapshot key react-native-onyx#610. As the higher level lib affects many parts of the app, there can be many cases to fix such as this one.
5. The issue was already present on the higher level lib before this PR.
6. The use case here is quite different from what we are doing in that PR. Cancelling payment feature is not linked to the Search page but I still raised a similar case in point 2.

What do you think?

[luacmartins]

I think it was a regression. The bug didn't exist before that PR and existed after it, even though the issue came from a higher level lib, I should have taken that into account. That's just my opinion though.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump onyx version to 2.0.89 #55299

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@parasharrajat @adelekennedy @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@rlinoz, @luacmartins, @parasharrajat, @adelekennedy, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Payment due tomorrow

[adelekennedy]

Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @parasharrajat  owed $250 via NewDot

[melvin-bot]

@rlinoz, @luacmartins, @parasharrajat, @adelekennedy, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...