[HOLD on #53493] [$250] [ iOS 17.2] App closes when back button pressed on PDF preview

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.88-4
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jjcoffee
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Add a PDF attachment to any chat
2. Open the PDF
3. Press the back button

Expected Result:

Return to the chat.

Actual Result:

App closes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

ios-app-2025-01-20_11.10.51.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021883275195164447950
• Upwork Job ID: 1883275195164447950
• Last Price Increase: 2025-02-01

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[jjcoffee]

I can repro (I'm the bug reporter), please assign me @MitchExpensify 🙏

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021883275195164447950

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App closes when back button pressed on PDF preview

What is the root cause of that problem?

We have an AttachmentModal nested inside the ReportAttachments modal (react-navigation).

App/src/pages/home/report/ReportAttachments.tsx

Lines 45 to 47 in b59f23b

	return (
	<AttachmentModal
	accountID={Number(accountID)}

When the back button is pressed, the closeModal function is triggered. Inside this function, we first call setIsModalOpen to close the AttachmentModal and then call the onModalClose callback to close the ReportAttachments modal (handled by react-navigation). However, due to asynchronous behavior, the ReportAttachments modal closes before the AttachmentModal, leading to a crash.

This issue can be reproduced with other types of attachments, not just PDFs.

App/src/components/AttachmentModal.tsx

Lines 389 to 398 in b59f23b

	const closeModal = useCallback(
	(shouldCallDirectly?: boolean) => {
	setIsModalOpen(false);
	if (typeof onModalClose === 'function') {
	if (shouldCallDirectly) {
	onModalClose();
	return;
	}
	attachmentModalHandler.handleModalClose(onModalClose);

Detail

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-26.at.18.42.25.mp4

What changes do you think we should make in order to solve the problem?

It seems there is already a plan to migrate modal to react-navigation. We can hold this until the PR for the migration is merged.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

We should close the ReportAttachments modal only after the AttachmentModal has fully closed. This can be achieved by moving the logic to close the ReportAttachments modal into the onModalHide callback.

App/src/components/AttachmentModal.tsx

Lines 500 to 503 in b59f23b

	onModalHide={() => {
	if (!isPDFLoadError.current) {
	onModalHide();
	}

   onModalHide={() => {
...
            if (typeof onModalClose === 'function') {
                if (shouldCallDirectly) {
                    onModalClose();
                    return;
                }
                attachmentModalHandler.handleModalClose(onModalClose);
            }
}

[MitchExpensify]

What do you think about the proposal @jjcoffee ?

[jjcoffee]

Asking for confirmation if this issue will be fixed as part of #53493.

[jjcoffee]

Still waiting for confirmation from @chrispader.

[chrispader]

Asking for confirmation if this issue will be fixed as part of #53493.

Sorry for the delay! Yes this should get fixed by the modal screen migration, as we will remove the modal (react-native-modal) entirely.

[jjcoffee]

Thanks!

@MitchExpensify I think we should hold on #53493, then we can retest once that's done.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MitchExpensify]

@MitchExpensify I think we should hold on #53493, then we can retest once that's done.

Sounds good @jjcoffee !

[melvin-bot]

@jjcoffee, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[chrispader]

There is a PR for this up now: #56219

[melvin-bot]

@jjcoffee, @MitchExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MitchExpensify]

Not overdue, melvin