Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standardize the pay button] IOUs #55874

Open
grgia opened this issue Jan 28, 2025 · 5 comments
Open

[Standardize the pay button] IOUs #55874

grgia opened this issue Jan 28, 2025 · 5 comments
Assignees
@hungvu193 @grgia @getusha
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Jan 28, 2025 •
edited
Loading

Design Doc Section

⚠️ MERGE HOLD ON BE ⚠️

This section is dependent on:
NVP changes:
#55873 (FE Migration)
https://github.com/Expensify/Expensify/issues/465082 (BE Migration)
https://github.com/Expensify/Expensify/issues/465077 (Setting the NVP)

New Command:
https://github.com/Expensify/Expensify/issues/465092

Goal

Update all pay buttons related to IOUs
@grgia grgia added the Daily KSv2 label Jan 28, 2025
@grgia grgia mentioned this issue Jan 28, 2025
Open
13 tasks
@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 3, 2025

@hungvu193, @grgia, @getusha Eep! 4 days overdue now. Issues have feelings too...

@hungvu193
Copy link
Contributor

Let's do this first.
@getusha Can you take over and implement this one?

@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Feb 4, 2025
@grgia
Copy link
Contributor Author

grgia commented Feb 6, 2025

@getusha are you taking this one

@hungvu193 hungvu193 mentioned this issue Feb 10, 2025
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 10, 2025
@hungvu193
Copy link
Contributor

Another PR is waiting for your review @getusha.
#56593 add the second line text for button (double decker button).

@getusha
Copy link
Contributor

getusha commented Feb 11, 2025

@getusha are you taking this one

yes, i'll raise the first draft soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hungvu193 hungvu193

@grgia grgia

@getusha getusha

Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hungvu193 @grgia @getusha