Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-13] [Due for payment 2025-02-10] Pusher PingPong is making clients go offline too often #56180

Open
tgolen opened this issue Jan 31, 2025 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@tgolen
Copy link
Contributor

tgolen commented Jan 31, 2025

Problem

Once the pusher pingpong was implemented in #55326, it's resulted in more clients being forced offline than I had expected. This prevents users from using the app.

Image

Solution

Turn off the portion of the ping-pong that forces clients to go offline when the PONG event is not received and analyze the logs to see what behavior is happening with the ping-pong so it can be dialed in better.

@tgolen tgolen added Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Internal Requires API changes or must be handled by Expensify staff labels Jan 31, 2025
@tgolen tgolen self-assigned this Jan 31, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 31, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 31, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@tgolen tgolen added the Reviewing Has a PR in review label Jan 31, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Hourly KSv2 labels Jan 31, 2025
@tgolen tgolen removed the DeployBlockerCash This issue or pull request should block deployment label Jan 31, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 3, 2025
@melvin-bot melvin-bot bot changed the title Pusher PingPong is making clients go offline too often [Due for payment 2025-02-10] Pusher PingPong is making clients go offline too often Feb 3, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 3, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 3, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-10. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 6, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-10] Pusher PingPong is making clients go offline too often [Due for payment 2025-02-13] [Due for payment 2025-02-10] Pusher PingPong is making clients go offline too often Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-13. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants