Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-19] "IN" is not translated to Spanish in Report Filter page #56503

Closed
1 of 8 tasks
mvtglobally opened this issue Feb 7, 2025 · 13 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Feb 7, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #50135
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequioa 15.2
App Component: Chat Report View

Action Performed:

Precond: app is in Spanish

  1. Access staging.new.expensify.com
  2. Go to Reports tab
  3. Choose Chats
  4. Try different filters
  5. Verify if shown result have chat name in the corner "In ...."

Expected Result:

"In" should be translated to Spanish (Em)

Actual Result:

In is shown in English

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @anmurali
@mvtglobally mvtglobally added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 7, 2025
@melvin-bot melvin-bot bot assigned techievivek and anmurali and unassigned techievivek Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mvtglobally mvtglobally changed the title Android - Distance - Unable to switch distance label unit when tapping on the label 56482 - PR 50135 - "IN" is not translated to Spanish in Report Filter page Feb 7, 2025
@nkdengineer
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

In is shown in English

What is the root cause of that problem?

We do not translate 'in' here

<Text style={styles.chatItemMessageHeaderPolicy}>In </Text>

What changes do you think we should make in order to solve the problem?

We should use translate('common.in')

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Feb 7, 2025

Regresison PR: #50135

@mvtglobally mvtglobally changed the title 56482 - PR 50135 - "IN" is not translated to Spanish in Report Filter page "IN" is not translated to Spanish in Report Filter page Feb 7, 2025
@techievivek
Copy link
Contributor

Removing the blocker label, it can be fixed via a followup.

@techievivek techievivek added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 7, 2025
@zfurtak
Copy link
Contributor

zfurtak commented Feb 7, 2025

Hi, can you assign me? :)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 9, 2025
@zfurtak
Copy link
Contributor

zfurtak commented Feb 9, 2025

The PR is ready for a review: #56590

@zfurtak
Copy link
Contributor

zfurtak commented Feb 11, 2025

I think this issue can be closed as I address the bug in the PR that is already merged. :)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 12, 2025
@melvin-bot melvin-bot bot changed the title "IN" is not translated to Spanish in Report Filter page [Due for payment 2025-02-19] "IN" is not translated to Spanish in Report Filter page Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.97-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

  • @zfurtak does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Feb 12, 2025

@DylanDylann @anmurali @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants