Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSQS Frontend Components: Update approvalAccount selector to be "Payment Account" on the Export Tab #56802

Open
yuwenmemon opened this issue Feb 13, 2025 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@yuwenmemon
Copy link
Contributor

Tracking Issue: https://github.com/Expensify/Expensify/issues/446352

Design Doc: https://docs.google.com/document/d/18g8cUtqiSwJce2a42d7uU1dLmxz6hjfVf1bIXwyz4PY/


@s77rt As discussed here, let's remove the A/P Approval Account selector in the Advanced Tab. Instead, we should create a "Payment Account" selector that will show the same bank accounts as before (although now they will be stored under paymentAccounts) but in the Export Tab:

Image

Finally, the ID of the selected account should be stored under the key paymentAccount in the config.

Let me know if you have any questions!

@yuwenmemon yuwenmemon added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@miljakljajic miljakljajic removed their assignment Feb 13, 2025
@miljakljajic miljakljajic added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 13, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Feb 13, 2025

Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.

@miljakljajic
Copy link
Contributor

still on maternity leave, reported here: https://expensify.slack.com/archives/C05P8G4A1SP/p1739465523347319

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 13, 2025
@s77rt
Copy link
Contributor

s77rt commented Feb 13, 2025

#56843

@muttmuure muttmuure removed their assignment Feb 14, 2025
@muttmuure muttmuure added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 14, 2025
Copy link

melvin-bot bot commented Feb 14, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants