Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Subscription - Back button on subscription leads to settings when opened from Concierge chat #56817

Open
2 of 8 tasks
IuliiaHerets opened this issue Feb 13, 2025 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola Moto G60 - Android 12 - Chrome
App Component: Other

Action Performed:

  1. Open the Expensify app.
  2. Open Concierge chat.
  3. Tap on "Claim Offer" on the top of the screen.
  4. Once redirected to "Subscription" tap on the back button on the top left corner.

Expected Result:

The user should land on Concierge chat again after using the back button.

Actual Result:

User lands on "Settings" when using back button on Subscription page, despite having entered from "Claim Offer" button on Concierge chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741586_1739430814082.cfab8c5f-33a8-495e-a349-57eca5dc4a65.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@parasharrajat
Copy link
Member

It may be related to new navigation changes

@mountiny mountiny assigned mountiny and unassigned grgia Feb 13, 2025
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Feb 13, 2025
@mountiny mountiny changed the title Subscription - Back button on subscription leads to settings when opened from Concierge chat [Navigation] Subscription - Back button on subscription leads to settings when opened from Concierge chat Feb 13, 2025
@mountiny
Copy link
Contributor

I will take this one over as its most likely related to the navigation changes. Looking at the flow, I do not think this has to be a blocker as its expected the UP action takes the user to the settings page above in the stack. The browser back button takes you to the concierge chat.

I will hold this for confirmation now before closing but defo not a blocker

@garrettmknight garrettmknight removed the Bug Something is broken. Auto assigns a BugZero manager. label Feb 13, 2025
@garrettmknight garrettmknight added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@SzymczakJ
Copy link
Contributor

I've created PR with fix. I didn't manage to make recordings for every platform, but tested this pretty robustly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants