Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Do not allow to enter issue expensify card flow unless the policy is provisioned #57391

Open
8 tasks
mountiny opened this issue Feb 25, 2025 · 9 comments
Open
8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 25, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07HPDRELLD/p1740392771429119

Action Performed:

Break down in numbered steps

  1. Enable the Expensify Card feature but doesn't settle bank account
  2. Go to member page
  3. Click on the member detail
  4. Click on the Add card
  5. Select the Expensify Card

Expected Result:

Describe what you think should've happened

We shouldn't display the Expensify option if users haven't connected their bank account and the cards have not been setup fully

Actual Result:

Describe what actually happened

Admin can enter this flow leading to error inevitably

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894333795848558635
  • Upwork Job ID: 1894333795848558635
  • Last Price Increase: 2025-02-25
  • Automatic offers:
    • DylanDylann | Reviewer | 106270114
Issue OwnerCurrent Issue Owner: @
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 25, 2025
@mountiny mountiny self-assigned this Feb 25, 2025
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot changed the title Do not allow to enter issue expensify card flow unless the policy is provisioned [$250] Do not allow to enter issue expensify card flow unless the policy is provisioned Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021894333795848558635

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@koko57
Copy link
Contributor

koko57 commented Feb 25, 2025

I would like to work on this issue 🙋‍♀

@koko57
Copy link
Contributor

koko57 commented Feb 25, 2025

I've also found an issue with the loader showing infinitely (until refresh or changing route and going back) #55124 (comment) when investigating #55124. If it's a simple fix I could fix both issues in one PR

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@mountiny
Copy link
Contributor Author

Thanks!

@koko57
Copy link
Contributor

koko57 commented Feb 25, 2025

Ok, so the problem with the loader is a more complex one - when creating a workspace offline and then enabling Expensify Card (also offline) and then going back online

Image Image

I'm getting Unauthorized Request for OpenPolicyProfilePage and OpenPolicyExpensifyCardPage and also I cannot delete the workspace (the error also in the screenshot)

So I will open the PR for displaying the card issue and I will check if the problem I described here was already reported and there is a separate ticket for that. If not I think we should open another issue

cc @mountiny @DylanDylann

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 25, 2025
@koko57
Copy link
Contributor

koko57 commented Feb 25, 2025

PR opened for review #57407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

4 participants