[$250] Bank account - Bank account icons are green when not hovered or clicked

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows.
3. Click Connect bank account.

Expected Result:

"Log into your bank" and "Connect manually" buttons should be grayed when not hovered or clicked.

Actual Result:

"Log into your bank" and "Connect manually" buttons are green when not hovered or clicked.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894449458017903941
• Upwork Job ID: 1894449458017903941
• Last Price Increase: 2025-02-25
• Automatic offers:
• paultsimura | Reviewer | 106276337

Issue Owner

Current Issue Owner: @paultsimura

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Bank account icons are green when not hovered or clicked

What is the root cause of that problem?

We explicitly set the iconFill to green:

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Line 232 in a59f464

iconFill={theme.iconMenu}

What changes do you think we should make in order to solve the problem?

Remove the explicit icon fill.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

None

[gurus00]

I am sure this is the issue on the Staging not on the Prod

[gurus00]

Please add label External.
I can fix this issue quickly

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-25 17:14:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Bank account icons are green when not hovered or clicked

What is the root cause of that problem?

Here we are using iconFill={theme.iconMenu} that turn the icons to green even when not clicked or hovered

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 251 to 268 in bc1a2e5

	<MenuItem
	title={translate('bankAccount.connectOnlineWithPlaid')}
	icon={Expensicons.Bank}
	iconFill={theme.iconMenu}
	disabled={!!isPlaidDisabled}
	onPress={handleConnectPlaid}
	shouldShowRightIcon
	wrapperStyle={[styles.cardMenuItem, styles.mt4]}
	/>
	)}
	<MenuItem
	title={translate('bankAccount.connectManually')}
	icon={Expensicons.Connect}
	iconFill={theme.iconMenu}
	onPress={handleConnectManually}
	shouldShowRightIcon
	wrapperStyle={[styles.cardMenuItem, styles.mt4]}
	/>

What changes do you think we should make in order to solve the problem?

we need to use

iconFill={theme.icon}

for both Menu Items

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI Bug, don't need test

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Results

[github-actions]

⚠️ @samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[MrMuzyk]

Caused by #55949. I'm the author of the PR and can fix it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894449458017903941

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[neil-marcellini]

Thanks @MrMuzyk, when will you have a fix ready?

[neil-marcellini]

After chatting with @MrMuzyk we are going to revert #55949 since it's causing several issues.