Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Broken character encoding in the OAuth callback page #3305

Open
Ivan-Shaml opened this issue Feb 10, 2025 · 0 comments
Open

[Bug]: Broken character encoding in the OAuth callback page #3305

Ivan-Shaml opened this issue Feb 10, 2025 · 0 comments
Labels
beginner-friendly bug good first issue

Comments

@Ivan-Shaml
Copy link
Member

Describe the Bug

Non-ASCII characters (e.g. French) are not displayed correctly in the OAuth callback page after login.

Log file or Error Message

no log files to provide

Reproduce the bug

  1. Log in to the client.
  2. Change your language to French.
  3. Log out.
  4. Log in again.
  5. On the callback page in the browser, all non-ASCII characters appear broken.

Expected Behavior

The page(s) has proper encoding, and all characters are displayed correctly

Screenshots

login_success_french

Additional context

HINT: Please examine the com.faforever.client.login.OAuthValuesReceiver class, particularly the writeResponse method.

The login_success.html and login_failed.html files are returned in the browser response based on the outcome of the login process. However, both HTML files lack a character encoding declaration in the <head> section. Please add necessary meta tag to ensure proper character encoding.

Which Operating System are you using?

Windows
@Ivan-Shaml Ivan-Shaml changed the title Broken character encoding in the oauth callback page [Bug] Broken character encoding in the OAuth callback page Feb 10, 2025
@Ivan-Shaml Ivan-Shaml changed the title [Bug] Broken character encoding in the OAuth callback page [Bug]: Broken character encoding in the OAuth callback page Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ivan-Shaml