Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Request SRv6 locator after zebra connection #18069

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

cscarpitta
Copy link
Contributor

When SRv6 is enabled and an SRv6 locator is specified in the BGP configuration, BGP may attempt to request SRv6 locator information from zebra before the connection is fully established. If this occurs, the request fails with the following error:

2025/02/06 16:37:32 BGP: [HR66R-TWQYD][EC 100663302] srv6_manager_get_locator: invalid zclient socket

As a result, BGP is unable to obtain the locator information, preventing SRv6 VPN from working.

This PR fixes the issue by ensuring BGP requests SRv6 locator information once the connection with zebra is successfully established.


This PR fixes intermittent failures in BGP SRv6 L3VPN topotests.

@frrbot frrbot bot added the bgp label Feb 8, 2025
@cscarpitta cscarpitta changed the title bgpd: Requests SRv6 locator after zebra connection bgpd: Request SRv6 locator after zebra connection Feb 8, 2025
When SRv6 is enabled and an SRv6 locator is specified in the BGP
configuration, BGP may attempt to request SRv6 locator information from
zebra before the connection is fully established. If this occurs, the
request fails with the following error:

```
2025/02/06 16:37:32 BGP: [HR66R-TWQYD][EC 100663302] srv6_manager_get_locator: invalid zclient socket
````

As a result, BGP is unable to obtain the locator information,
preventing SRv6 VPN from working.

This commit fixes the issue by ensuring BGP requests SRv6 locator
information once the connection with zebra is successfully established.

Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta cscarpitta force-pushed the fix/bgp_request_srv6_locator branch from 99ce5bb to 16640b6 Compare February 8, 2025 23:54
@cscarpitta
Copy link
Contributor Author

@Jafaral @donaldsharp

This is a fix for intermittent failures in the BGP SRv6 L3VPN topotests.

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Jafaral
Copy link
Member

Jafaral commented Feb 12, 2025

@Mergifyio backport dev/10.3 stable/10.2

Copy link

mergify bot commented Feb 12, 2025

backport dev/10.3 stable/10.2

✅ Backports have been created

@Jafaral Jafaral merged commit d275f55 into FRRouting:master Feb 12, 2025
13 checks passed
donaldsharp added a commit that referenced this pull request Feb 12, 2025
bgpd: Request SRv6 locator after zebra connection (backport #18069)
donaldsharp added a commit that referenced this pull request Feb 12, 2025
bgpd: Request SRv6 locator after zebra connection (backport #18069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants