Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bfd fixups (backport #18026) #18131

Closed
wants to merge 2 commits into from
Closed

Bfd fixups (backport #18026) #18131

wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 12, 2025

Some issues found by coverity

This is an automatic backport of pull request #18026 done by Mergify.

@donaldsharp @mergify
bfdd: Use pass by reference instead of pass by value for a struct
c4f561e 
The function bfd_key_lookup is currently sending by value for
a now very large structure.  Let's convert this over to pass
by reference.  This is noticed by coverity.

Signed-off-by: Donald Sharp <[email protected]>
(cherry picked from commit 6d80d0c)

# Conflicts:
#	bfdd/bfd.h
#	bfdd/bfdd_nb_config.c
#	bfdd/bfdd_nb_state.c
@donaldsharp @mergify
bfdd: Use pass by reference for bfd_key_delete
c50beea 
Coverity is pointing out that bfd_key_delete is
passing by value instead of reference for a very
large structure.  Double plus not good.

Signed-off-by: Donald Sharp <[email protected]>
(cherry picked from commit 8119e16)

# Conflicts:
#	bfdd/bfd.h
@mergify mergify bot added the conflicts label Feb 12, 2025
@mergify Mergify
Copy link
Author

mergify bot commented Feb 12, 2025

Cherry-pick of 6d80d0c has failed:

On branch mergify/bp/stable/10.1/pr-18026
Your branch is up to date with 'origin/stable/10.1'.

You are currently cherry-picking commit 6d80d0c59.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   bfdd/bfd.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bfdd/bfd.h
	both modified:   bfdd/bfdd_nb_config.c
	both modified:   bfdd/bfdd_nb_state.c

Cherry-pick of 8119e16 has failed:

On branch mergify/bp/stable/10.1/pr-18026
Your branch is ahead of 'origin/stable/10.1' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 8119e167b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   bfdd/bfd.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bfdd/bfd.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Feb 12, 2025
Merged
@frrbot frrbot bot added the bfd label Feb 12, 2025
@donaldsharp
Copy link
Member

this code is not on 10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bfd size/L stable/10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@donaldsharp