pimd: Fix PIM VRF support (send register/register stop in VRF) #18216
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9461953 and 8ebcc02, transmission of PIM register and register stop messages was changed to use a separate socket. However, that socket is not bound to a possible VRF, so the messages were sent in the default VRF instead. Call vrf_bind() once after socket creation and when the VRF is ready to ensure transmission in the correct VRF. vrf_bind() handles the non-VRF case (i.e. VRF_DEFAULT) automatically, so it may be called unconditionally. Signed-off-by: Martin Buck <[email protected]>
|
CI failure looks unrelated to me |
|
I just reran the failed test. |
|
@gromit1811 Do you mind adding or expanding an existing topotest to cover this case? That way we know the fix actually works and it won't break again. |
|
@Mergifyio backport dev/10.3 stable/10.2 stable/10.1 |
✅ Backports have been created
|
|
I'll have a look at the topotest, but it will take a couple of days |
|
I will merge this one, and if you get around writing a test, that would be great and we can merge that independent of this PR. |
This was referenced Feb 24, 2025
Jafaral
added a commit
that referenced
this pull request
Feb 24, 2025
pimd: Fix PIM VRF support (send register/register stop in VRF) (backport #18216)
donaldsharp
added a commit
that referenced
this pull request
Feb 25, 2025
pimd: Fix PIM VRF support (send register/register stop in VRF) (backport #18216)
donaldsharp
added a commit
that referenced
this pull request
Feb 25, 2025
pimd: Fix PIM VRF support (send register/register stop in VRF) (backport #18216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9461953 and
8ebcc02, transmission of PIM register and register stop messages was changed to use a separate socket. However, that socket is not bound to a possible VRF, so the messages were sent in the default VRF instead. Call vrf_bind() once after socket creation and when the VRF is ready to ensure transmission in the correct VRF. vrf_bind() handles the non-VRF case (i.e. VRF_DEFAULT) automatically, so it may be called unconditionally.