pim: Fix autorp group joins #18225
Merged
pim: Fix autorp group joins #18225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests to show group joins are workign? |
Yeah, I can extend the autorp test. The issue would have shown up if autorp was disabled, then later re-enabled, then the groups would not have gotten joined again. I will add that test to verify. |
Group joining got broken when moving the autorp socket to open/close as needed. This fixes it so autorp group joining is properly handled as part of opening the socket. Signed-off-by: Nathan Bahr <[email protected]>
|
@Mergifyio backport dev/10.3 stable/10.2 |
✅ Backports have been created
|
This was referenced Feb 24, 2025
donaldsharp
added a commit
that referenced
this pull request
Feb 25, 2025
pim: Fix autorp group joins (backport #18225)
donaldsharp
added a commit
that referenced
this pull request
Feb 25, 2025
pim: Fix autorp group joins (backport #18225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group joining got broken when moving the autorp socket to open/close as needed. This fixes it so autorp group joining is properly handled as part of opening the socket.