Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer overflow on sending smoke and explo messages #501

Open
FreeSlave opened this issue Dec 31, 2024 · 0 comments
Open

Integer overflow on sending smoke and explo messages #501

FreeSlave opened this issue Dec 31, 2024 · 0 comments

Comments

@FreeSlave
Copy link
Member

FreeSlave commented Dec 31, 2024

If you set low or too high value for a damage of entity derived from CGrenade, the values sent in TE_EXPLOSION and TE_SMOKE are getting overflown, because they're sent as bytes.

Example: set sk_plr_9mmAR_grenade1 to 10 and test the AR grenade in singleplayer. The explosion and smoke effects will be too large.

Probably need to clamp between 1 and 255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant