Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI_DrawString can get stuck until integer overflow if bounds are too small #27

Open
noodlecollie opened this issue Sep 27, 2019 · 1 comment

Comments

@noodlecollie
Copy link
Contributor

I noticed after neglecting to set a size for a table view that the menu would take up to 10 seconds to render a single frame. After some investigation I worked out that it was UI_DrawString that was being slow. I think that because the height of the table view was less than the height of the font, the function got stuck in an infinite loop and kept "wrapping" the line/increasing the value of yy until it overflowed, thereby eventually failing the check if ( yy < (yy + h) - charH ).

@a1batross
Copy link
Member

Thanks for the report! I will look into it, as soon as throw off an illness and get back to my workstation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants