Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Cache Enhancements #94

Open
lucasreed opened this issue Apr 5, 2022 · 1 comment
Open

Additional Cache Enhancements #94

lucasreed opened this issue Apr 5, 2022 · 1 comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: should Should be addressed shortly

Comments

@lucasreed
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running locally in quick succession it is likely you will hit rate limits on the artifacthub API, especially if you have a lot of helm releases.

Describe the solution you'd like
A local cache file that is on by default. We'll want the file to include the datetime of when it was last pulled. There can be a configurable expiry duration that will bypass the cache. It should hold all the search data that was gathered from artifacthub. If nova is run in quick succession after a helm chart is added to the cluster, there needs to be a fallback to call artifacthub only for new things that are not in the cache.

Describe alternatives you've considered
Nothing right now.

Additional context
N/A

@github-actions github-actions bot added the stale Marked as stale by stalebot label Jun 5, 2022
@sudermanjr sudermanjr reopened this Jun 12, 2022
@sudermanjr sudermanjr added the pinned Prevents stalebot from removing label Jun 12, 2022
@github-actions github-actions bot removed the stale Marked as stale by stalebot label Jun 13, 2022
@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label May 16, 2023
@sudermanjr sudermanjr changed the title Feature(cache file when using artifacthub) Additional Cache Enhancements May 16, 2023
@sudermanjr
Copy link
Member

Now that we're downloading the entire file from artifacthub now, it should be easy to enhance how we manage and cache that file.

@sudermanjr sudermanjr added the priority: should Should be addressed shortly label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: should Should be addressed shortly
Projects
None yet
Development

No branches or pull requests

2 participants