Remove react/jsx-no-literals from eslint-config-faithlife

[ddunkin]

I don't see a justification for why react/jsx-no-literals is enabled. My guess is it's to encourage developers to put strings in localizable bundles. It doesn't, though, it just encourages developers to wrap literals in {''}. Many of our projects override the rule to off. I propose we remove the rule from eslint-config-faithlife.

[randymarsh77]

Not like these bugs wouldn’t be caught another way, but I have experienced this rule catching things like unintentional white space (or more rarely, other typos). More often when updating old code en masse. FWIW.

[randymarsh77]

Welp, my example of this bug being caught on modern versions of this config and eslint aren't actually caught. For example, under [email protected] + [email protected], [email protected] + [email protected] and [email protected] + [email protected] we have the following failure to catch an unintended typo that also passes prettier:

And, just to sanity check:

And, I guess this kind of error is just a proposal

Carry on.