Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on doctrine/persistence on v1.23 prevents from upgrading fully to symfony 6.4 #899

Closed
oaygalenq opened this issue Aug 30, 2024 · 3 comments

Comments

@oaygalenq
Copy link

oaygalenq commented Aug 30, 2024

Hi,

The dependency to doctrine/persistence v1 or v2 prevents from upgrading symfony/doctrine-bridge to v6.4 because it has a dependency on doctrine/persistence v3. Could you please add support of doctrine/persistence v3?

Regards

@Jubeki
Copy link

Jubeki commented Oct 3, 2024

Are you sure this is related to the fackerphp/faker package?

Because this is not a composer dependency:

Faker/composer.json

Lines 16 to 20 in 4dae775

"require": {
"php": "^7.4 || ^8.0",
"psr/container": "^1.0 || ^2.0",
"symfony/deprecation-contracts": "^2.2 || ^3.0"
},

@DvDty
Copy link

DvDty commented Oct 3, 2024

Are you sure this is related to the fackerphp/faker package?

Because this is not a composer dependency:

Faker/composer.json

Lines 16 to 20 in 4dae775

"require": {
"php": "^7.4 || ^8.0",
"psr/container": "^1.0 || ^2.0",
"symfony/deprecation-contracts": "^2.2 || ^3.0"
},

It's listed as dev dependency:

Faker/composer.json

Lines 21 to 24 in 4dae775

"require-dev": {
"ext-intl": "*",
"bamarni/composer-bin-plugin": "^1.4.1",
"doctrine/persistence": "^1.3 || ^2.0",

@oaygalenq how are you installing Faker?

@Jubeki
Copy link

Jubeki commented Oct 3, 2024

Dev dependencies are not installed on the project where Faker is being used, so it should not be a problem for this case.

This should be updated for the tests and so one, but should have no influence on installing faker as a composer dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants