Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-Replay incorrect block context initiation #557

Closed
cabrador opened this issue Jul 20, 2023 · 2 comments
Closed

API-Replay incorrect block context initiation #557

cabrador opened this issue Jul 20, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cabrador
Copy link
Collaborator

As of right now, any call to this contract https://ftmscan.com/address/0xe0c38b2a8d09aad53f1c67734b9a95e43d5981c0 (or basically any contract, that requires blockHash) will not be replayed correctly.

The bug lies in how block context is created within API-Replay, especially that we do not save block hash into it.

This require further investigation on how to acquire block hash.
As far as I know we have two options:

  1. Get EvmHeader - that might require opening gossip.Store, though further investigation has to be made.
  2. Record blockHash into Substate
@cabrador cabrador added the bug Something isn't working label Jul 20, 2023
@cabrador
Copy link
Collaborator Author

cabrador commented Nov 7, 2023

Since getHash has been implemented to Carmen, this error should not occur anymore although it did not help. I will continue my investigation.

@cabrador
Copy link
Collaborator Author

moved to #983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cabrador