Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan support #556

Open
maichmueller opened this issue Sep 4, 2024 · 3 comments
Open

Conan support #556

maichmueller opened this issue Sep 4, 2024 · 3 comments

Comments

@maichmueller
Copy link
Contributor

Hi,

I think Conan, the package manager, support in ALE would be useful.

There are 2 ways to achieve it from my understanding:

  1. the repo provides its own conanfile.py that configures the package and is maintained by the project itself.
  2. a conan-center recipe is added which configures the Conan package for ALE and is maintained at their index-repo.

Number 2 has the advantage that a consumer could add the repo with a simple line in their dependencies and it will be downloaded from the index-repo and added to their pojecct.
I suppose 2 could make use of 1 as well but I haven't looked into this yet.

I could provide a solution for 1 though. Let me know if this is something you would like to be added.

@pseudo-rnd-thoughts
Copy link
Member

If you would be happy to maintain number 2 then I would happy to that

@maichmueller
Copy link
Contributor Author

hi @pseudo-rnd-thoughts , I looked into number 2 but I am afraid it is too much of a learning process right now for me to get done. Option 1 I know how to do and it is still valuable for conan users. Someone else (or I if i get around to it in the future) can then reference that work to start option 2 I guess.
Option 1 woud mean adding 2 files conandata.yml and conanfile.py on the top level which people can use to build the ale package with conan create . --build=missing for their cache.

if you are happy with that i can add a PR.

@pseudo-rnd-thoughts
Copy link
Member

That should be ok, I'm just worried about adding more features that needs to be maintained and won't be used much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants