-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Environment should terminate when adroit hand pen drops the pen #112
Comments
Hi, I was just following the thread and wanted to check if the condition to check if the pen is dropped needs to be restored which was removed in #111 ? # penalty for dropping the pen
if obj_pos[2] < 0.075:
reward -= 5
# removed code
terminated = True
|
Hey, @leonasting @jjshoots what testing had you done? Thanks! |
This was awhile ago and I don't quite remember, but if I recall correctly, the AdroitHand environments are no-termination environments, negative rewards are incurred in perpetuity (or until the truncation). So adding a termination signal to HandPen specifically doesn't make sense. At least that's as much discussion on this as I can remember. |
I'm interested in testing. Let me know what tests, you want me to perform. Based on the code and environment, I can infer any agent action after the pen is out of hands is redundant. In the meantime, I will capture few screenshots of terminal frames with the earlier code. |
@leonasting |
@leonasting excellent I think it is clear that
Now can you show A simple ablation study should do it |
Proposal
In AdroitHandPen, when the agent drops the pen, there is no way to recover, but the environment still does not terminate. The proposal, as in #111, is to enable environment termination on pen drop.
The text was updated successfully, but these errors were encountered: