We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think adding a cache in DefaultTypeResolver can improve performance and memoery allocations.
DefaultTypeResolver
kafkaflow/src/KafkaFlow.Serializer/DefaultTypeResolver.cs
Line 15 in d662b9d
private readonly ConcurrentDictionary<string, Type> _consumeTypeCache = new(StringComparer.Ordinal); private readonly ConcurrentDictionary<Type, string> _produceTypeCache = new(); (...) return typeName is null ? null : _consumeTypeCache.GetOrAdd(typeName, Type.GetType); (...) string messageTypeName = _produceTypeCache.GetOrAdd( messageType, static messageType => $"{messageType.FullName}, {messageType.Assembly.GetName().Name}"); context.Headers.SetString(MessageType, messageTypeName);
Yes
No response
The text was updated successfully, but these errors were encountered:
Also why DefaultTypeResolver is basically a transient dependency?
Sorry, something went wrong.
Add caching to DefaultTypeResolver (issue Farfetch#437)
d5ae9dd
Successfully merging a pull request may close this issue.
Is your request related to a problem you have?
I think adding a cache in
DefaultTypeResolver
can improve performance and memoery allocations.kafkaflow/src/KafkaFlow.Serializer/DefaultTypeResolver.cs
Line 15 in d662b9d
Describe the solution you'd like
Are you able to help bring it to life and contribute with a Pull Request?
Yes
Additional context
No response
The text was updated successfully, but these errors were encountered: