Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Generalize and export BCValues #1152

Closed
wants to merge 4 commits into from
Closed

WIP: Generalize and export BCValues #1152

wants to merge 4 commits into from

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Feb 14, 2025

I think BCValues could be generalized a bit, to both make it easier to follow our internal code, and it could facilitate working with dofs directly for e.g. AffineConstraints (ref #1119).

So far just some initial WIP, but the main idea would be to have an interface for getting the combination of the dof(s) associated with a given coordinate on a boundary entity.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.72%. Comparing base (5f20e7b) to head (808d327).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Dofs/ConstraintHandler.jl 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
+ Coverage   93.69%   93.72%   +0.02%     
==========================================
  Files          39       39              
  Lines        6237     6233       -4     
==========================================
- Hits         5844     5842       -2     
+ Misses        393      391       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant