Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute path to databasefilePath in world file unsustainable #40

Closed
daewok opened this issue Apr 5, 2021 · 3 comments
Closed

Absolute path to databasefilePath in world file unsustainable #40

daewok opened this issue Apr 5, 2021 · 3 comments

Comments

@daewok
Copy link
Collaborator

daewok commented Apr 5, 2021

It's not very user or developer friendly to require this repo be installed in a specific place to use it. Especially when that absolute path is under /home since it mandates a user name...

Could we pass the world files through xacro to use $(find ...)? Or maybe another approach?

@woensug-choi
Copy link
Collaborator

Both transient current and tidal oscillation database csv file can be defined in relative path and absolute path.
Currently, the relative path method written as below direct to the directory of the dave repo.

<databasefilePath>transientOceanCurrentDatabase.csv</databasefilePath>

<databasefilePath>ACT1951_1_Annual_2021.csv</databasefilePath>

So it's pretty much a relative path already considering that the glider repo will be merged to dave repo sometime after reorganizations happening at the dave repo.

@woensug-choi
Copy link
Collaborator

Field-Robotics-Lab/dave#190

This shall fix it.

@woensug-choi
Copy link
Collaborator

#66 includes the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants