Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate Page Kit Upgrade PRs do not include a change log #638

Closed
i-like-robots opened this issue Oct 28, 2019 · 2 comments
Closed

Renovate Page Kit Upgrade PRs do not include a change log #638

i-like-robots opened this issue Oct 28, 2019 · 2 comments
Labels
Help wanted Extra attention is needed Housekeeping Mainly repo maintenance

Comments

@i-like-robots
Copy link
Contributor

The Page Kit change log is maintained in a file at the repository root (changelog.md) and the change list added to each release description.

Renovate has been configured to open a single pull request for all Page Kit packages but the upgrade PRs it has opened so far on our apps have not included any change log.

I think this is because each package specifies a repository.directory property in its manifest. This enables direct linking of the source code on npm but Renovate also follows this.

I'm not aware of any Renovate settings which can configure the location of a change log.

@i-like-robots i-like-robots added Bug Something isn't working Help wanted Extra attention is needed Housekeeping Mainly repo maintenance labels Oct 28, 2019
@i-like-robots
Copy link
Contributor Author

i-like-robots commented Oct 28, 2019

Actually... I think this is more likely due to the repository being private. I'll leave this issue open to catch any other feedback about this problem.

@i-like-robots i-like-robots removed the Bug Something isn't working label Oct 28, 2019
@i-like-robots i-like-robots pinned this issue Oct 28, 2019
@i-like-robots
Copy link
Contributor Author

Closing as the repo is now public and this issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Extra attention is needed Housekeeping Mainly repo maintenance
Projects
None yet
Development

No branches or pull requests

1 participant