Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom sticky headers #728

Open
i-like-robots opened this issue Jan 21, 2020 · 1 comment
Open

Support for custom sticky headers #728

i-like-robots opened this issue Jan 21, 2020 · 1 comment
Labels
Help wanted Extra attention is needed New feature Proposal

Comments

@i-like-robots
Copy link
Contributor

i-like-robots commented Jan 21, 2020

The article page currently has a custom markup injected into the sticky header. This markup contains social and share links which replaces the MyFT logo on the right-hand side.

Because this feature is currently broken and had previously been switched off for 12 months or more we have not re-implemented it as part of the migration, however we may need to in future.

Adding an option (customStickyHeaderRightHandSideContent) and passing it down through the tree of components would be brittle and hard to rationalise. Because it is a rarely used feature it would also create a supportability problem.

I propose that if we do need this feature then we create a generic CustomStickyHeader component. It would maintain the drawer menu and search bar buttons but otherwise be a blank container for implementations to insert custom content.

Example:

import { Header, CustomStickyHeader } from '@financial-times/dotcom-ui-header';

<Header showStickyHeader={false} />
<CustomStickyHeader>{myContent}</CustomStickyHeader>
@kavanagh
Copy link
Member

kavanagh commented Jan 21, 2020

The MyFT Page Timeline and Topic views have a sticky element. Maybe that could use this.
Also Content Packages on article page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Extra attention is needed New feature Proposal
Projects
None yet
Development

No branches or pull requests

2 participants