From 9cc02f18c548fc4c4981378d2fe480479ee27fde Mon Sep 17 00:00:00 2001
From: Rowan Manning <accounts+github@rowanmanning.com>
Date: Thu, 21 Nov 2019 09:35:47 +0000
Subject: [PATCH] Remove checkboxes from the Google Sheet (#287)

The checkboxes in the Google sheet are causing us a few issues. Mostly
they promote the idea that the competencies for a level are a checklist,
and that completing the checklist will get you promoted.

The checkboxes have now been removed from the sheet, and the chart at
the top is now based on whether any evidence has been provided for the
competencies.
---
 script/deploy-google-sheets.js | 52 ++++++++--------------------------
 1 file changed, 12 insertions(+), 40 deletions(-)

diff --git a/script/deploy-google-sheets.js b/script/deploy-google-sheets.js
index 021be9c..7826164 100755
--- a/script/deploy-google-sheets.js
+++ b/script/deploy-google-sheets.js
@@ -210,7 +210,7 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 			// Add the actual data for the level
 			batchedUpdates.push(createBatchCellUpdate(sheetId, [
 				[''], // Empty cell for chart
-				['Area', 'Competency', 'Done?', 'Evidence'],
+				['Area', 'Competency', 'Evidence'],
 				...competenciesForLevel.map(competency => {
 					let content = competency.summary;
 					if (competency.examples.length) {
@@ -223,30 +223,6 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 				})
 			]));
 
-			// Set up the checkbox column for the level
-			batchedUpdates.push({
-				repeatCell: {
-					range: {
-						sheetId,
-						startRowIndex: 2,
-						endRowIndex: competenciesForLevel.length + 2,
-						startColumnIndex: 2,
-						endColumnIndex: 3
-					},
-					cell: {
-						dataValidation: {
-							condition: {
-								type: 'BOOLEAN'
-							}
-						},
-						userEnteredFormat: {
-							horizontalAlignment: 'CENTER'
-						}
-					},
-					fields: 'dataValidation,userEnteredFormat(horizontalAlignment)'
-				}
-			});
-
 			// Resize the columns for the level
 			batchedUpdates.push(createBatchColumnResize(sheetId, {
 				startIndex: 0,
@@ -258,10 +234,6 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 			}));
 			batchedUpdates.push(createBatchColumnResize(sheetId, {
 				startIndex: 2,
-				width: 50
-			}));
-			batchedUpdates.push(createBatchColumnResize(sheetId, {
-				startIndex: 3,
 				width: 500
 			}));
 
@@ -271,7 +243,7 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 					range: {
 						sheetId,
 						dimension: 'COLUMNS',
-						startIndex: 4
+						startIndex: 3
 					}
 				}
 			});
@@ -285,7 +257,7 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 						startRowIndex: 0,
 						endRowIndex: 1,
 						startColumnIndex: 0,
-						endColumnIndex: 4
+						endColumnIndex: 3
 					},
 					mergeType: 'MERGE_ROWS'
 				}
@@ -327,23 +299,23 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 			batchedUpdates.push(createBatchCellUpdate(calculationSheetId, [
 				[
 					'Technical',
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,'${level.name}'!C3:C=TRUE,'${level.name}'!A3:A=A1)),"<>#N/A")`,
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT('${level.name}'!C3:C=TRUE),'${level.name}'!A3:A=A1)),"<>#N/A")`
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT(ISBLANK('${level.name}'!C3:C)),'${level.name}'!A3:A=A1)),"<>#N/A")`,
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,ISBLANK('${level.name}'!C3:C),'${level.name}'!A3:A=A1)),"<>#N/A")`
 				],
 				[
 					'Communication',
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,'${level.name}'!C3:C=TRUE,'${level.name}'!A3:A=A2)),"<>#N/A")`,
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT('${level.name}'!C3:C=TRUE),'${level.name}'!A3:A=A2)),"<>#N/A")`
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT(ISBLANK('${level.name}'!C3:C)),'${level.name}'!A3:A=A2)),"<>#N/A")`,
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,ISBLANK('${level.name}'!C3:C),'${level.name}'!A3:A=A2)),"<>#N/A")`
 				],
 				[
 					'Delivery',
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,'${level.name}'!C3:C=TRUE,'${level.name}'!A3:A=A3)),"<>#N/A")`,
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT('${level.name}'!C3:C=TRUE),'${level.name}'!A3:A=A3)),"<>#N/A")`
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT(ISBLANK('${level.name}'!C3:C)),'${level.name}'!A3:A=A3)),"<>#N/A")`,
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,ISBLANK('${level.name}'!C3:C),'${level.name}'!A3:A=A3)),"<>#N/A")`
 				],
 				[
 					'Leadership',
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,'${level.name}'!C3:C=TRUE,'${level.name}'!A3:A=A4)),"<>#N/A")`,
-					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT('${level.name}'!C3:C=TRUE),'${level.name}'!A3:A=A4)),"<>#N/A")`
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,NOT(ISBLANK('${level.name}'!C3:C)),'${level.name}'!A3:A=A4)),"<>#N/A")`,
+					`=SUMIF(ROWS(FILTER('${level.name}'!C3:C,ISBLANK('${level.name}'!C3:C),'${level.name}'!A3:A=A4)),"<>#N/A")`
 				]
 			]));
 
@@ -477,7 +449,7 @@ async function deployGoogleSheets({competencies, competenciesVersion, jsonAuthDa
 								},
 								offsetXPixels: 0,
 								offsetYPixels: 0,
-								widthPixels: 1150,
+								widthPixels: 1100,
 								heightPixels: 200
 							}
 						}