From ef6d9f16bdea27cfa3478da43577dd1d94b642e8 Mon Sep 17 00:00:00 2001 From: klaus triendl Date: Wed, 2 Sep 2020 23:01:42 +0200 Subject: [PATCH] Fix 'implicit fallthrough' warnings (addresses issue #16) --- src/algorithm.cpp | 8 ++++++-- src/process.cpp | 4 ++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/algorithm.cpp b/src/algorithm.cpp index 00ea0b6e3..bc808c13e 100644 --- a/src/algorithm.cpp +++ b/src/algorithm.cpp @@ -13,6 +13,7 @@ #include #include #include +#include // macro to shift bitmask by a single bit #define SHIFT_BITMASK(ptr, mask) if (mask & 0x01) { mask = 0x80; ++ptr; } else mask >>= 1; @@ -212,10 +213,13 @@ std::string algorithm::url_encode(const std::string& str) result += str[pos]; break; } - // else pass through to next case - case ' ': + BOOST_FALLTHROUGH; + case ' ': + BOOST_FALLTHROUGH; case '$': case '&': case '+': case ',': case '/': case ':': + BOOST_FALLTHROUGH; case ';': case '=': case '?': case '@': case '"': case '<': + BOOST_FALLTHROUGH; case '>': case '#': case '%': case '{': case '}': case '|': case '\\': case '^': case '~': case '[': case ']': case '`': // the character needs to be encoded diff --git a/src/process.cpp b/src/process.cpp index 7b976e1bc..4baab29ba 100644 --- a/src/process.cpp +++ b/src/process.cpp @@ -18,6 +18,7 @@ #include #endif +#include #include #include @@ -63,8 +64,11 @@ BOOL WINAPI console_ctrl_handler(DWORD ctrl_type) { switch(ctrl_type) { case CTRL_C_EVENT: + BOOST_FALLTHROUGH; case CTRL_BREAK_EVENT: + BOOST_FALLTHROUGH; case CTRL_CLOSE_EVENT: + BOOST_FALLTHROUGH; case CTRL_SHUTDOWN_EVENT: process::shutdown(); return TRUE;