Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose readiness/liveness probes #24

Open
khvn26 opened this issue Feb 25, 2025 · 2 comments
Open

Expose readiness/liveness probes #24

khvn26 opened this issue Feb 25, 2025 · 2 comments

Comments

@khvn26
Copy link
Member

khvn26 commented Feb 25, 2025

Currently we expect orchestrators to execute a resource-heavy management command for each check. This might cause resource starvation on smaller clusters. In fact, we need to expose two health checks, preferably as HTTP endpoints:

  • A simple liveness probe that means the task processor is running.
  • A readiness probes that makes sure the database connections are healthy.
@khvn26 khvn26 changed the title Expose an HTTP health check Expose readiness/liveness probes Feb 25, 2025
@rolodato
Copy link
Member

+1 to separate liveness and readiness checks - see Flagsmith/flagsmith#5151 for an example.

I would also suggest making both checks be served over HTTP to avoid spawning new processes on the pods to run the health checks.

@khvn26
Copy link
Member Author

khvn26 commented Feb 25, 2025

With task-processor being a Django app installed on top of Core API, task-processor containers are in fact capable of using Core API's readiness and liveness probes introduced in

The following PRs need to be merged before we close this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants