Uninitialized scalar field

[Lecrapouille]

Minor bug concerning class CmdFunction final : public CmdBase

Coverity scan says line 100:

CID 281693 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member value is not initialized in this constructor nor in any functions that it calls.

and line 118:

1. member_decl: Class member declaration for value.

but seems to me this member variable is set but never used.

[FlorianRappl]

Hi @Lecrapouille - great catch!

Do you mind making a PR? Would be much appreciated! Thanks 👍

[Lecrapouille]

How do you want I fix it ? I do not know well this library and therefore I'm not sure to clearly understand what the code does. They are several solutions:

1. Is print_value() is supposed to return stringify(value); instead of return "" ? And what initial value shall I set to value ?

		template<typename T>
		class CmdFunction final : public CmdBase {
		public:
			explicit CmdFunction(const std::string& name, const std::string& alternative, const std::string& description, bool required, bool dominant) :
				CmdBase(name, alternative, description, required, dominant, ArgumentCountChecker<T>::Variadic) {
			}

			virtual bool parse(std::ostream& output, std::ostream& error) {
				try {
					CallbackArgs args { arguments, output, error };
					value = callback(args);
					emptyValue_ = false; // FIX HERE ?
					return true;
				} catch (...) {
					return false;
				}
			}

			virtual std::string print_value() const {
				return emptyValue_ ? "" : stringify(value); // FIX HERE ?
			}

			std::function<T(CallbackArgs&)> callback;
			T value;
		private: // FIX HERE ?
			bool emptyValue_ = true; 
		};

2. Remove the member variable and do not check callback() return code

callback(args);

3. Use local variable, get the result of callback() then void it:

T value = callback(args);
(void) value;
return true;